Changeset 1847

Timestamp:

12/08/06 17:34:09 (2 years ago)

Author:

mrenzmann

Message:

The fix for CVE-2006-6332 in r1842 was not entirely correct. In
encode_ie() the bound check did not consider that each byte from
the IE causes two bytes to be written into buffer. That could
lead to a kernel oops, but does not allow code injection. This is
now fixed.

Due to the type of this problem it does not trigger another
urgent security bugfix release. v0.9.3 is at the door anyway.

Reported-by: Joachim Gleisner <jg@suse.de>

Files:

• trunk/net80211/ieee80211_wireless.c (modified) (1 diff)

trunk/net80211/ieee80211_wireless.c

@@ -1566 +1566 @@
-        bufsize -= leader_len;
-        p += leader_len;
-
-
-
+
-                p += sprintf(p, "%02x", ie[i]);
+                bufsize -= 2;
+        }
-        return (i == ielen ? p - (u_int8_t *)buf : 0);
-}