Changeset 2280

Timestamp:

04/21/07 03:52:56 (1 year ago)

Author:

mentor

Message:

Use unsigned integers for parameters for some IOCTLs. Thus the value is always GEQ 0. Remove now redundant checks in the few places that they were being done.

Files:

• trunk/net80211/ieee80211_wireless.c (modified) (16 diffs)

trunk/net80211/ieee80211_wireless.c

@@ -1464 +1464 @@
-                IEEE80211_ADDR_COPY(req->addr[i].sa_data, se->se_bssid);
-        set_quality(&req->qual[i], se->se_rssi, -95);
- = i + 1
+++
-
-        return 0;
@@ -2079 +2079 @@
-        struct ieee80211com *ic = vap->iv_ic;
-        struct ieee80211_rsnparms *rsn = &vap->iv_bss->ni_rsn;
-int *i = (
-
-
+unsigned int *i = (unsigned 
+unsigned 
+unsigned 
-        int retv = 0;
-        int j, caps;
@@ -2139 +2139 @@
-                break;
-        case IEEE80211_PARAM_MCASTKEYLEN:
-!(0 < value && value <= IEEE80211_KEYBUF_SIZE)
+value > IEEE80211_KEYBUF_SIZE
-                        return -EINVAL;
-                /* XXX no way to verify driver capability */
@@ -2176 +2176 @@
-                break;
-        case IEEE80211_PARAM_UCASTKEYLEN:
-!(0 < value && value <= IEEE80211_KEYBUF_SIZE)
+value > IEEE80211_KEYBUF_SIZE
-                        return -EINVAL;
-                /* XXX no way to verify driver capability */
@@ -2471 +2471 @@
-                break;
-        case IEEE80211_PARAM_COVERAGE_CLASS:
->= 0 && value 
+
-                        ic->ic_coverageclass = value;
-                        if (IS_UP_AUTO(vap))
@@ -2571 +2571 @@
-        /* set the same params on the xr vap device if exists */
-        if (vap->iv_xrvap && !(vap->iv_flags & IEEE80211_F_XR)) {
-info,w,
+ info, w, 
-                vap->iv_xrvap->iv_ath_cap &= IEEE80211_ATHC_XR; /* XR vap does not support  any superG features */
-        } 
@@ -2650 +2650 @@
-        struct ieee80211com *ic = vap->iv_ic;
-        struct ieee80211_rsnparms *rsn = &vap->iv_bss->ni_rsn;
-int *param = (
+unsigned int *param = (unsigned 
-        
-        switch (param[0]) {
@@ -2933 +2933 @@
-        if (vap->iv_opmode != IEEE80211_M_STA)
-                return -EINVAL;
- 
+
-                return -EINVAL;
-        /* NB: wri->length is validated by the wireless extensions code */
@@ -3627 +3627 @@
-{
-        struct ieee80211vap *vap = dev->priv;
-int *param = (
-
-
+unsigned int *param = (unsigned 
+unsigned 
+unsigned 
-        struct ieee80211_wme_state *wme = &vap->iv_ic->ic_wme;
-
-        switch (param[0]) {
-        case IEEE80211_WMMPARAMS_CWMIN:
-< 0 || param[3] 
+
-                        return -EINVAL;
-                if (bss) {
@@ -3647 +3647 @@
-                break;
-        case IEEE80211_WMMPARAMS_CWMAX:
-< 0 || param[3] 
+
-                        return -EINVAL;
-                if (bss) {
@@ -3660 +3660 @@
-                break;
-        case IEEE80211_WMMPARAMS_AIFS:
-< 0 || param[3] 
+
-                        return -EINVAL; 
-                if (bss) {
@@ -3673 +3673 @@
-                break;
-        case IEEE80211_WMMPARAMS_TXOPLIMIT:
-< 0 || param[3] 
+
-                        return -EINVAL;
-                if (bss) {
@@ -3690 +3690 @@
-                break;
-        case IEEE80211_WMMPARAMS_ACM:
-< 0 || param[3] 
+
-                        return -EINVAL;
-                /* ACM bit applies to BSS case only */
@@ -3698 +3698 @@
-                break;
-        case IEEE80211_WMMPARAMS_NOACKPOLICY:
-< 0 || param[3] 
+
-                        return -EINVAL; 
-                /* ack policy applies to non-BSS case only */
@@ -3715 +3715 @@
-{
-        struct ieee80211vap *vap = dev->priv;
-int *param = (
-
+unsigned int *param = (unsigned 
+unsigned 
-        struct ieee80211_wme_state *wme = &vap->iv_ic->ic_wme;
-        struct chanAccParams *chanParams = (param[2] == 0) ? 
@@ -4096 +4096 @@
-        struct ieee80211vap *vap = dev->priv;
-        struct ieee80211com *ic = vap->iv_ic;
-int *param = (
+unsigned int *param = (unsigned 
-
-        if (!(ic->ic_flags & IEEE80211_F_DOTH))