Changeset 3825

Timestamp:

07/30/08 23:33:40 (5 months ago)

Author:

proski

Message:

Protect against probing AR2425 if HAL doesn't support it

AR2424 and AR2425 share the same PCI ID. Probing AR2425 with HAL that
doesn't support it is problematic. It causes an unhandled NMI and puts
the device to a non-functional state. After that, even HAL that
supports AR2425 won't be able to use the device until the system is
rebooted.

Reject AR2425 devices if HAL doesn't positively indicate support for
them.

Files:

• madwifi/trunk/ath/if_ath_pci.c (modified) (1 diff)

madwifi/trunk/ath/if_ath_pci.c

@@ -191 +191 @@
-        }
-
+/*
+ * Reject new MAC revisions if HAL doesn't support AR2425.  Ideally, it could
+ * be done in the PCI ID table, but AR2424 and AR2425 share the same vendor ID
+ * 168c:001c.
+ */
+#ifndef AH_SUPPORT_2425
+#define AR5K_SREV               0x4020  /* MAC revision */
+#define AR5K_SREV_CUTOFF        0xE0    /* Cutoff revision */
+        {
+                u_int32_t mac_rev = readl(mem + AR5K_SREV);
+                if (mac_rev > AR5K_SREV_CUTOFF)
+                {
+                        printk(KERN_ERR "%s: HAL doesn't support MAC revision "
+                               "0x%02x\n", dev_info, mac_rev);
+                        goto bad2;
+                }
+        }
+#endif
+
-        dev = alloc_netdev(sizeof(struct ath_pci_softc), "wifi%d", ether_setup);
-        if (dev == NULL) {