Ticket #1940 (new defect)

Opened 3 months ago

Last modified 2 months ago

wds 1, STA does not look at receiver address of DStoDS packet

Reported by: andrew.lunn@ascom.ch Assigned to:
Priority: minor Milestone:
Component: madwifi: other Version: trunk
Keywords: WDS 4 addr reciever address Cc:
Patch is attached: 1

Description

SVN Revision: 3626

I have an STA with MAC address 06:0e:8e:13:ab:29. It is associated to an AP with 06:1a:c1:35:ce:e2. Both have iwpriv wds 1, so can send/recieve 4 address frames.

I added a few debug prints to understand my problem: 

wifi1/ath1 DSDS 06:1a:c1:35:ce:12->06:1a:c1:35:c5:cf(06:1a:c1:35:ce:e2->06:0e:8e:13:ab:1f)
wifi1/ath1 delivering data from 06:1a:c1:35:ce:12->06:1a:c1:35:c5:cf

The STA has received a DSTODS frame. The frame has come from the AP the STA is associated to, however the receiving station address is of another AP. The station should discard this frame. However it does not. It passes the frame up the stack. This is wrong, and causes my bridge to incorrectly learn the source address on the wrong port. Further packets from this source address then get directed out the wrong port.

I took a quick look at the code. I don't see anywhere in 80211_input() which looks at the receiver address in DSTODS frames. I think a check needs to be added.....

Andrew

Attachments

4address_sta.diff (1.1 kB) - added by anonymous on 06/04/08 12:14:03.

Change History

06/04/08 12:13:35 changed by anonymous

Soon to be attached is a patch which fixes this. I've tested it in my 5 node setup which uses WDS in the somewhat strange setup i have. However, the STA is clearly wrong in passing packets which are not addressed to it up the IP stack.

Please consider incorporating this into the trunk.

06/04/08 12:14:03 changed by anonymous

  • attachment 4address_sta.diff added.

06/04/08 12:15:52 changed by andrew.lunn@ascom.ch

Ups, i forgot to change the email address when submitting the patch. Also, its needs a signed off.

signed-off-by Andrew Lunn <andrew.lunn@ascom.ch>

06/04/08 14:25:43 changed by mrenzmann

  • patch_attached set to 1.

Add/Change #1940 (wds 1, STA does not look at receiver address of DStoDS packet)