Ticket #950 (closed task: fixed)

Opened 2 years ago

Last modified 2 years ago

madwifi wont compile for linux-2.9.19-rc1-git2,3,4,5,6,7

Reported by: anonymous Assigned to: kelmo
Priority: minor Milestone: version 0.9.3
Component: madwifi: other Version:
Keywords: Cc:
Patch is attached: 1 Pending:

Description

due to different definitions of request_irq between linux-2.6.19-rc1 and linux-2.6.19-rc1-git2 and beyond, madwifi ng-1747 and ng-1748 will not compile.

request_irq is defined in linux/include/linux/interrupt.h

the quick and dirty workaround is to retain interrupt.h as interrupt.h.original and to copy the interrupt.h from linux-2.6.19-rc1 as interrupt.h.madwifi. to compile madwifi, the appropriate symbolic link is defined.

a mor through fix involves makeing prototype definitaion changes based on the "official" kernel definitions in interrupt.h and applying them to Maadwifi components as necessary. this will result in a madwifi that will not compile for linux-2.6.19-rc1 and earlier however.

Attachments

2.6.19-ptregs-fix.diff (1.3 kB) - added by Žilvinas Valinskas <valins@soften.ktu.lt> on 10/12/06 18:17:39.
Signed-off-by: Žilvinas Valinskas <valins@soften.ktu.lt>
madwifi-2.6.19-ptregs-fix.diff (1.1 kB) - added by kelmo on 10/14/06 07:53:47.
revised compile fix

Change History

10/11/06 17:54:35 changed by chrishisgen@allvantage.com

left off my e-mail. sorry. chris

10/11/06 18:07:42 changed by mrenzmann

Thanks for the report. Another ticket that is related to 2.6.19-rc-something is #940.

However, the priority of tracking changes in release candidates or pre-releases of new kernels is low, since these are sometimes rapidly moving targets. So it's likely that this issue (and the one described in #940) will not be fixed before 2.6.19 is released.

10/12/06 18:17:39 changed by Žilvinas Valinskas <valins@soften.ktu.lt>

  • attachment 2.6.19-ptregs-fix.diff added.

Signed-off-by: Žilvinas Valinskas <valins@soften.ktu.lt>

10/12/06 19:56:55 changed by mrenzmann

Thanks for the patch. Since I do not follow kernel development very closely currently: does the patch also cover the issue for the various release candidates (as reported above)?

10/12/06 20:08:43 changed by chrishisgen@allvantage.com

sorry for the mis-understanding. what i provided was a kludge work-around to compile madwifi for linux-2.6.19-rc1-git1-git9. Note that not all the gits compile, specifically as I recall git6 does not. the issue for ptregs (#940) is different. As far as I can tell, 2.6.19-rc1-git1 and beyond represent a phase change in how things are defined in include/linux/interrupt.h. based on the advice of not shooting at moving targets, all I have provided is a recipe for a work-aroung and a clean comple.

by the way it works, I am using the work around now: Linux herodotus 2.6.19-rc1-git9-cwh-0 #1 SMP Thu Oct 12 04:28:29 EDT 2006 i686 GNU/Linux bash-3.1$ iwconfig lo no wireless extensions.

eth0 no wireless extensions.

wifi0 no wireless extensions.

Warning: Driver for device ath0 has been compiled with version 21 of Wireless Extension, while this program supports up to version 19. Some things may be broken...

ath0 IEEE 802.11g ESSID:"Bradley-6540-Talisman-WRT54GS" Nickname:"herodotus"

Mode:Managed Frequency:2.437 GHz Access Point: 00:13:10:F9:7C:12 Bit Rate:48 Mb/s Tx-Power:11 dBm Sensitivity=0/3 Retry:off RTS thr:off Fragment thr:off Power Management:off Link Quality=45/94 Signal level=-51 dBm Noise level=-96 dBm Rx invalid nwid:9789 Rx invalid crypt:0 Rx invalid frag:0 Tx excessive retries:0 Invalid misc:0 Missed beacon:0

sit0 no wireless extensions.

cheers chris

10/13/06 12:30:52 changed by Žilvinas Valinskas <valins@soften.ktu.lt>

I think this patch will work for any 2.6.19-rc+ kernels. x86 (as Chris verfied) and Xscale/BE ;) least to say.

10/14/06 07:52:36 changed by kelmo

  • status changed from new to assigned.
  • owner set to kelmo.
  • milestone set to version 0.9.3.

Patch does not work. Following suggestions:

  • no need for extra backets around #if statement
  • use comma's instead of dot point for arguments to KERNEL_VERSION()

Will attach new trivial patch and commit it.

We should investigate if other changes are required for changes in linux interupt code.

10/14/06 07:53:47 changed by kelmo

  • attachment madwifi-2.6.19-ptregs-fix.diff added.

revised compile fix

10/14/06 07:54:04 changed by kelmo

  • patch_attached set to 1.

10/14/06 07:59:07 changed by kelmo

  • status changed from assigned to closed.
  • resolution set to fixed.

r1752. Thanks Žilvinas.

10/16/06 14:54:33 changed by Žilvinas Valinskas <<valins@soften.ktu.lt>

Thank you, Kelmo. My bad ;) next time I will check patch actually compiles ;)

02/26/07 13:35:34 changed by chris.alex.thomas@gmail.com

ok, call me stupid, but here goes.

I want this patch, so I can click one of the attachments, only to get a HTML page, I can't seem to obtain the ACTUAL patch so I can apply against my source code I downloaded.

someone please tell me how to do it ?

chris thomas

02/26/07 13:52:48 changed by mrenzmann

At the bottom of the mentioned HTML page(s) you'll find something like "Download in other formats: Original Format". This should give you what you're looking for. :)

(follow-up: ↓ 13 ) 04/07/07 22:30:36 changed by Les

Hello

I hope someone can help me with this I have been trying to get my Dlink Airplus DWL G520 wireless adapter (rev.B) adapter to work on Redhat Fedora 5 Kernel (2.6.20-12307.Fc5). I have installed Madwifi and everything seem to go very well until the end. When I type dhclient ath0 nothing happens and I can't ping any outside sites. I have a separate ethernet card in the machine that is giving me access. I also have the hard drive split with Windows XP Pro on the other partition and the wireless card works very well.

This is what I get with iwconfig Ath0:

Warning: Driver for device ath0 has been compiled with version 21 of Wireless Extension, while this program supports up to version 19. Some things may be broken...

ath0 IEEE 802.11g ESSID:"home" Nickname:""

Mode:Managed Frequency:2.422 GHz Access Point: 00:0C:41:AA:9A:6B Bit Rate:1 Mb/s Tx-Power:18 dBm Sensitivity=0/3 Retry:off RTS thr:off Fragment thr:off Encryption key:7B96-0086-D4 Security mode:restricted Power Management:off Link Quality=16/94 Signal level=-81 dBm Noise level=-91 dBm Rx invalid nwid:106 Rx invalid crypt:0 Rx invalid frag:0 Tx excessive retries:0 Invalid misc:0 Missed beacon:0

If someone could please help me, I would greatly appreciate it. I have been trying forever to get it to work.

(in reply to: ↑ 12 ) 04/10/07 07:51:52 changed by mrenzmann

Replying to Les:

I hope someone can help me with this ...

That's a support question and in addition doesn't seem to be related to this ticket. Please redirect your request to our regular support channels.

Add/Change #950 (madwifi wont compile for linux-2.9.19-rc1-git2,3,4,5,6,7)